Skip to content

Fixes #14129 fixes forward message edit ordering #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhaskarraksahb
Copy link

@bhaskarraksahb bhaskarraksahb commented May 11, 2025

First time contributor checklist

Contributor checklist

  • Device Moto g54, android 14
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Message record was being used to determine the timestamp for the conversational message. It is possible that message was edited, in that case edited timestamp will be applied before forward message is called. Instead of using message record we can rely on original message timestamp so that even if message was edited, original message timestamp will be used before forward is called.

signal_fix.mp4
signal_fix_forward.mp4

@alex-signal
Copy link
Contributor

Hi! can you please confirm that forwarding an unedited message still works properly?

@bhaskarraksahb
Copy link
Author

Hi! can you please confirm that forwarding an unedited message still works properly?

Hello @alex-signal have added the evidence. Please help to check. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants