Use a blurhash for blurred story backgrounds #7133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
mainbranchnpm run readyrun passes successfully (more about tests here)Description
Stories render very slowly on some devices. I believe this is due to the use of
backdrop-filter: blur(90px)used in the background, which is CPU intensive. This might affect Linux particularly, because nearly all Windows/macOS users would have GPU acceleration, which likely helps render blur faster: https://community.signalusers.org/t/stories-extremely-slow-on-linux-desktop/60588I have replaced the current CSS background/blur mechanism with a Blurhash, which renders a lot more efficiently, at least on my laptop (I have no good way to show this objectively). On my end, stories now play at full framerate instead of 4-5 FPS thanks to the Blurhash. This does mean the blur effect looks significantly different, overall looking better for images/videos that don't have a uniform background (though that is subjective)
Before (CSS blur)
After (blurhash)