-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add DNG as a valid photo filetype #6108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Nice! Current open ticket for it is #5337 |
|
@max-signal I see you self assigned the open ticket for this issue. Just wanted to point out this exists now. |
|
@sashaweiss-signal @max-signal is there anything else I can do to help this along? |
|
@ianrahman when I investigated this last time, there were few changes we needed to make related to file sizes to resolve issues sending RAW files. The first of those was 425bf68, and there will be a few more to follow. I’ll circle back to this PR once I’ve finished the others. |
|
I still have this issue with DNG files on the iPhone 17 Pro for recently acquired raw photos. Older ones (maybe 1 week old) can be correctly sent as photos. But I realized that sending takes very long due to the file size. I would propose a setting to auto convert raw photos to compressed jpg before sending, this would solve all issues with raw photos. I assume most people do not want to share the raw photos anyway via signal, and if so, one could attach them as file instead of an image. |
|
@max-signal I’m not sure you need to land those other changes prior to this PR. Aren’t the file size checks the same as those used for potentially large image types such as .tif? If you have notes from your prior investigation I’d be happy to continue to push this over the finish line. |
Any thoughts or updates @max-signal? Thanks! |
Some RAW files were running into (I think, iirc) the 8 MB limit that’s imposed on certain images in certain places. |
# Conflicts: # SignalServiceKit/Util/ImageMetadata/ImageMetadata.swift
b273a7b to
cd7ffb3
Compare
First time contributor checklist
Contributor checklist
Description
Adds support for DNG as a valid image format. Resolves #4298 and #5337
Tested on two physical devices with RAW images captured on the iPhone and on a different DNG-generating camera.