Allow importing with exports-aware Typescript #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrb-hub
approved these changes
Apr 25, 2025
|
@charlag thank you for the Pull Request! Could you take look at the Contributor License Agreement and fill the form if it is alright with you? |
|
hi! yes, I'm waiting for the approval from my employer |
|
CLA signed. |
Trying to import the library could run into the following issue: error TS7016: Could not find a declaration file for module '@signalapp/sqlcipher'. '.../node_modules/@signalapp/sqlcipher/dist/index.mjs' implicitly has an 'any' type. There are types at '.../node_modules/@signalapp/sqlcipher/dist/lib/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@signalapp/sqlcipher' library may need to update its package.json or typings. The issue comes from mismatch where index.mjs does not automatically map to index.d.ts (it would have to be index.d.mts). The solution is to add types to export. The other "type" key could be removed but is left in for now for compatibility with old tsc versions.
charlag
force-pushed
the
package-json-export-types
branch
from
28a0bc5 to
c0f9cfa
Compare
|
I rebased it and put the types condition first so that esbuild does not complain |
charlag
force-pushed
the
package-json-export-types
branch
3 times, most recently
from
bdcdea2 to
c0f9cfa
Compare
|
Thank you! This will be released in 2.0.2 shortly ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to import the library could run into the following issue:
error TS7016: Could not find a declaration file for module '@signalapp/sqlcipher'. '.../node_modules/@signalapp/sqlcipher/dist/index.mjs' implicitly has an 'any' type.
There are types at '.../node_modules/@signalapp/sqlcipher/dist/lib/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@signalapp/sqlcipher' library may need to update its package.json or typings.
The issue comes from mismatch where index.mjs does not automatically
map to index.d.ts (it would have to be index.d.mts).
The solution is to add types to export. The other "type" key could
be removed but is left in for now for compatibility with old tsc
versions.
The issue was discussed here:
microsoft/TypeScript#52363
And here is an example of the similar solution in another library:
onsetsoftware/automerge-patcher#1