Skip to content

fix: crash after closing the database #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: crash after closing the database #5

merged 1 commit into from
Apr 28, 2025

Conversation

indutny-signal
Copy link
Contributor

No description provided.

scottnonnenberg-signal
scottnonnenberg-signal approved these changes Apr 28, 2025
View reviewed changes
Copy link

@scottnonnenberg-signal scottnonnenberg-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Interesting that there's already nullptr checking inside of FromExternal but we have to do it again after FromExternal returns.

@indutny-signal indutny-signal merged commit b4d9e35 into main Apr 28, 2025
4 checks passed
@indutny-signal indutny-signal deleted the fix/crash-in-statement branch April 28, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottnonnenberg-signal scottnonnenberg-signal scottnonnenberg-signal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indutny-signal @scottnonnenberg-signal