Skip to content

e2e tests, CF, agent and guest #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 22, 2025
Merged

e2e tests, CF, agent and guest #1173

merged 19 commits into from
May 22, 2025

Conversation

giavac
Copy link
Collaborator

@giavac giavac commented Feb 13, 2025

Description

Adds e2e tests for Call Fabric scenarios like Agent and Customer (guest token) joining the same cXML conference.

  • One creates a cXML application with a static script
  • One creates a cXML application with an external URL
  • Another uses a static cXML script to connect a customer (guest token) to a stream (this is currently commented out)

It requires two new ENV vars:

  • EXTERNAL_URL_FOR_CXML, pointing to the external URL to be used in the second scenario.
  • CXML_STREAM_URL, pointing to the desired stream URL.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 88f679e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@giavac giavac changed the title WIP - e2e tests, CF, agent and guest e2e tests, CF, agent and guest Feb 25, 2025
@iAmmar7
Copy link
Member

iAmmar7 commented Feb 26, 2025

I remember one more thing; since this is a CF e2e test, do you mind adding this to the Playwright "callfabric" project here? Currently, it is probably in the "default" project.

@giavac giavac requested a review from iAmmar7 February 26, 2025 18:34
iAmmar7
iAmmar7 previously approved these changes Feb 27, 2025
Copy link
Member

@iAmmar7 iAmmar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for these amazing tests. 🚀

Let's update the ENV for the production.

@giavac giavac requested a review from ryanwi March 7, 2025 08:17
jpsantosbh
jpsantosbh previously approved these changes May 20, 2025
@ryanwi
Copy link
Contributor

ryanwi commented May 22, 2025

tests are green

@ryanwi
Copy link
Contributor

ryanwi commented May 22, 2025

I had to re-run the default one, but it passed on second time

@giavac giavac requested review from a team May 22, 2025 06:56
Copy link
Contributor

@ayeminag ayeminag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giavac giavac merged commit 2bfa2bb into main May 22, 2025
49 of 51 checks passed
@giavac giavac deleted the cf_e2e_tests branch May 22, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants