Skip to content

skip origin in prepare_public_folder.sh #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

skip origin in prepare_public_folder.sh #1221

merged 1 commit into from
May 20, 2025

Conversation

jpsantosbh
Copy link
Collaborator

Description

Since origin is not a branch we need to skip it too.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

Copy link

changeset-bot bot commented May 20, 2025

⚠️ No Changeset found

Latest commit: 1403b65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jpsantosbh jpsantosbh requested a review from ryanwi May 20, 2025 18:00
@jpsantosbh jpsantosbh merged commit 36d677a into main May 20, 2025
22 of 25 checks passed
@jpsantosbh jpsantosbh deleted the joao/skip_origin branch May 20, 2025 18:40
@iAmmar7
Copy link
Member

iAmmar7 commented May 21, 2025

The prepare_public_folder.sh is only used in the update-playground CI. This has been failing for a long time and still fails. I believe the issue is not only with the origin, but there are other things we need to debug.

I have a WIP PR for this: #1215 (this is still not enough, I need to prioritize and debug it further)

CC: @ryanwi

@jpsantosbh
Copy link
Collaborator Author

:-( The syntax only works on Mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants