Skip to content

Conversation

@jpsantosbh
Copy link
Collaborator

Description

A new approach trying to make the early invites more stable. Instead of forcing an early invite after the first non-host candidate. This new implementation allows all FAST candidates to be gathered, potentially even completing the gathering. If a single candidate takes longer than 300ms to gether, then we try an early invite with the candidates gathered so far.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025

🦋 Changeset detected

Latest commit: 116f791

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@signalwire/webrtc Patch
@signalwire/js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpsantosbh jpsantosbh marked this pull request as draft September 30, 2025 22:54
@jpsantosbh
Copy link
Collaborator Author

I need to cleanup unwanted the files from the main branch

@jpsantosbh jpsantosbh changed the base branch from main to main_video_v3 October 6, 2025 15:39
@jpsantosbh jpsantosbh marked this pull request as ready for review October 6, 2025 15:39
@jpsantosbh jpsantosbh requested review from giavac and iAmmar7 and removed request for iAmmar7 October 6, 2025 15:39
this.resetNeedResume()

if (this.isOffer) {
// only when it's an offer that means the negotiation is done
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this comment (or better, on the reasons for this comment)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it's an answer, the signalingState is stable earlier on the client side in comparison with the server side, which only has the one SDP. In some cases, this leaves room for the client side to fire onnegotiationeed events since the media is not connecting. That is why for incoming calls they need to keep the negotiating flag true until we have a successful response from the verto.answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants