-
Couldn't load subscription status.
- Fork 18
New Early Invite Implementation (Cherrypick from main) #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main_video_v3
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 116f791 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I need to cleanup unwanted the files from the |
| this.resetNeedResume() | ||
|
|
||
| if (this.isOffer) { | ||
| // only when it's an offer that means the negotiation is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this comment (or better, on the reasons for this comment)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it's an answer, the signalingState is stable earlier on the client side in comparison with the server side, which only has the one SDP. In some cases, this leaves room for the client side to fire onnegotiationeed events since the media is not connecting. That is why for incoming calls they need to keep the negotiating flag true until we have a successful response from the verto.answer.
Description
A new approach trying to make the early invites more stable. Instead of forcing an early invite after the first non-host candidate. This new implementation allows all FAST candidates to be gathered, potentially even completing the gathering. If a single candidate takes longer than 300ms to gether, then we try an early invite with the candidates gathered so far.
Type of change
Code snippets
In case of new feature or breaking changes, please include code snippets.