modify japanise copy bug #304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| displayTransform, | ||
| regex | ||
| ) | ||
| let newValue = newPlainTextValue === '@' ? |
There was a problem hiding this comment.
This assumes that mentions are only triggered using @ which is not the case. If I understand the approach correctly then this should take all possible trigger characters into account.
There was a problem hiding this comment.
Also newPlainTextValue is the entire value in the textarea. So it would only fix the problem in the case the textarea is completely empty. I'm afraid this PR doesn't really bring us any further in fixing the problem.
timsu
pushed a commit
to cryptagon/react-mentions
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242
What did you change (functionally and technically)?
When input two or more syllable words and then touch space key or select word, to be copied.
So I add code to ignore
applyChangeToValue(), if there is no @.I modify this and actually check it, it will work for Japanese.