-
Notifications
You must be signed in to change notification settings - Fork 15
Add dsse tests for rekor v2 entries #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a49e9b7 to
12eff8c
Compare
|
Oh I need to add the custom trusted root... |
|
also need to rerun the generator on these using the conformance-oidc-token |
12eff8c to
eb5ee13
Compare
|
Not sure why python is failing here, but sigstore-java fails as expected (which is to be expected, I designed around it). However sigstore-go seems to want to check signature in the timestamp before verifying the dsse properties. Every test fails with @jku when you get back, if I still haven't figured out the python failures, maybe you could take a quick look |
|
sigstore-python says
with the reason from rfc3161-client (the timestamp client):
Checking the timestamp in the test content: there is indeed no certificate at all in the timestamp -- this is by spec but surprising to me. So two potential things to look at:
|
I am 99% sure this is true. I will send a fix to sigstore-python when I have a moment to also write a regression test |
I know we talked about this in person, but just adding in here for posterity. Sigstore-java timestamp requests, by default, do no request the certificate be embedded. Spec here: https://www.ietf.org/rfc/rfc3161.txt |
eb5ee13 to
148f32d
Compare
|
updated tests and readmes. Weirdly sigstore-go is failing conformance (failure cases are passing?). I'll have to go check that out. Since sigstore-java doesn't have an attest command yet, I'm still using the custom code in #sigstore/sigstore-java#1029 |
|
the python fix is in now: If you modify the hash in |
Signed-off-by: Appu Goundan <[email protected]>
148f32d to
9401112
Compare
we think the test cases look ok and have two clients that agree so I'm fine with merging this -- would be good to look at this before we make a release though |
Similar to #175 for rekor v2. Will verify against clients before moving on.
Based off the bundles in : sigstore/sigstore-java#1031
Created using experimental dsse signer in: sigstore/sigstore-java#1029
This doesn't have failure cases for issues with the bundle other than the dsse structure