Skip to content

Release 2.6.0 -- add TOTP endpoints #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 64 commits into from
Sep 24, 2025
Merged

Release 2.6.0 -- add TOTP endpoints #140

merged 64 commits into from
Sep 24, 2025

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Sep 22, 2025

Added

  • Added new endpoints to support TOTP and allow the decommissioning of the serverless-mfa-api services.
    • POST /totp
    • POST /totp/{id}/validate
    • DELETE /totp/{id}

Changed

  • Various refactorings and development improvements.

briskt and others added 30 commits May 30, 2025 14:07
@briskt
Merge branch 'main' into develop
61cf03b
@briskt
Merge pull request #127 from silinternational/main
150d272 
merge back to develop
@ethancanne
Update CODEOWNERS
e5fcf94
@ethancanne
Merge pull request #128 from sil-org/rename-org
b15a75a 
Update CODEOWNERS
@briskt
add the POST /totp endpoint which creates a new TOTP
46d5a35
@briskt
make api-key tests a bit more precise
d517caf
@briskt
refactor router to reduce duplication and remove an external dependency
3dea567
@briskt
limit test server to DELETE
c3471c6
@briskt
add /router to Docker image
4230fbf
@briskt
clean up .dockerignore
8f52fd7
@briskt
add documentation for POST /totp
995c106
@briskt
Merge branch 'new-totp-endpoint' into route-refactor
940426d
@briskt
remove unused containers from the Docker Compose configuration
cd6f2a7
@briskt
remove incorrect note in the open API spec
62dfc1d
@briskt
create TOTP table in "make dbinit"
3a4cba5
@briskt
CDK doesn't need to be in the Dockerfile
1736edd
@briskt
don't return the error details in authentication response
f825c6f
@briskt
add missing route, BeginRegistration, which was defined for Lambda
f732781 
but not for http server, and I unfortunately based router on the http server. Oops.
@briskt
use CDK and SAM to serve the Lambda locally
c592228
@briskt
add some documentation details for clarity (PR feedback)
4de9c3b
@briskt
PR feedback: simplify region assignment
677b643
@briskt
Merge pull request #129 from sil-org/new-totp-endpoint
e4b81ae 
add the POST /totp endpoint which creates a new TOTP
@briskt
Merge branch 'develop' into route-refactor
2f60d6c
@briskt
Merge branch 'route-refactor' into misc
bb13f4a
@briskt
Merge branch 'misc' into cdk-sam-testing
1835c16
@briskt
address a SonarQube security alert about log injection
e71f1d9
@briskt
new test helper newPasscode()
97a89a1
@briskt
implement DELETE /totp/{uuid} endpoint
5199dae
@briskt
remove satori/go-uuid
c183360
@briskt
new test helper newRequest
7ebb231
briskt added 20 commits September 18, 2025 13:44
@briskt
Merge pull request #134 from sil-org/feature/remove-satori
3051f62 
remove satori/go-uuid
@briskt
Merge branch 'develop' into feature/totp-validate
87dbb03
@briskt
move response error consts to global scope
12aaa92
@briskt
do not respond to client with a detailed error message (again)
fbe11c8
@briskt
don't use a double pointer, even though json.Decode handles it OK
f866572
@briskt
move mux init outside test loop
5c43f82
@briskt
Merge pull request #135 from sil-org/feature/totp-validate
88db0e9 
implement POST /totp/{uuid}/validate endpoint
@briskt
Merge branch 'develop' into feature/simplify-routes
83e7e50
@briskt
Merge pull request #136 from sil-org/feature/simplify-routes
05a0ed5 
simplify route table
@briskt
fix TOTP Validate - decrypt and use the actual secret
896f37c
@briskt
log errors but don't send the details to the client
1eda72e
@briskt
refine the simpleError type to be a bit more useful
2ef424d
@briskt
didn't intend to commit this
ee2bf57
@briskt
remove unused code
80a7339
@briskt
Merge pull request #137 from sil-org/fix-totp-validate
f946511 
fix TOTP Validate - decrypt and use the actual secret
@briskt
PR feedback (typo, nested errors.Is, default in switch, use const)
f55dfd7
@briskt
rename local variable by Sonar recommendation
dc28fad
@briskt
Merge pull request #138 from sil-org/safe-response
f1c99db 
log errors but don't send the details to the client
@briskt
Merge pull request #139 from sil-org/remove-unused
36639c5 
remove unused code
@briskt
remove unnecessary indirection
a769b05
@briskt briskt changed the title Production Release -- add TOTP endpoints Release 2.6.0 -- add TOTP endpoints Sep 22, 2025
jason-jackson
jason-jackson approved these changes Sep 24, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.7% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt merged commit ba5e552 into main Sep 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt

@hobbitronics hobbitronics Awaiting requested review from hobbitronics

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @jason-jackson @ethancanne