-
-
Notifications
You must be signed in to change notification settings - Fork 10
Implement cascading deletion of user roles and edits with project visibility #3971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: imnasnainaec <[email protected]>
…ation Co-authored-by: imnasnainaec <[email protected]>
Co-authored-by: imnasnainaec <[email protected]>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3971 +/- ##
==========================================
+ Coverage 74.58% 74.66% +0.07%
==========================================
Files 293 293
Lines 10817 10890 +73
Branches 1353 1364 +11
==========================================
+ Hits 8068 8131 +63
- Misses 2354 2362 +8
- Partials 395 397 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imnasnainaec reviewed all commit messages.
Reviewable status: 0 of 15 files reviewed, all discussions resolved (waiting on @copilot)
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing to get user info should fail the contents.
@jasonleenaylor reviewed 2 of 5 files at r2, 12 of 13 files at r3, all commit messages.
Reviewable status: 14 of 15 files reviewed, all discussions resolved (waiting on @copilot and @imnasnainaec)
Co-authored-by: jasonleenaylor <[email protected]>
Fixed in e7d9591. When
Previously, the catch block only logged and showed a warning toast, leaving |
Implement cascading deletion of user roles and edits with project visibility
Backend Changes
DeleteUserto cascade delete all associated UserRole and UserEdit records. Added validation to prevent admin user deletion (returns 403).GetUserProjectsreturns project info and roles for deletion confirmation.Tests
Added 5 test cases covering:
Frontend Changes
getUserProjects()function.Screenshots
User without projects

User with lots of projects, some archived

Roles translated for UI language

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
This change is