-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove netstandard1.6 replace with netstandard2.0 #202
Conversation
…ove related conditional compilation. Should fix issues where a library is compiled against netstandard2.0 but the consumer is a net8.0 project which results in the runtime error: Could not load type 'Icu.SortKey' from assembly 'icu.net'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Also needs a line in CHANGELOG.md
(I guess this is a breaking change).
@ermshiperete I added a changelog summary and removed the ReliabilityContract attributes from non framework builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a breaking change, the commit message needs a line +semver:major
so that the major version number gets bumped.
@@ -16,6 +16,20 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
## [Unreleased] | |||
|
|||
### Breaking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(After the fact: this should be ### Removed
)
See #203 for follow-up. |
This PR attempts to remove support for netstanard1.6 as this requires a custom SortKey class which triggers down stream issues with a number of projects. The main cause of this is as follows:
SIL.WritingSystems
netstandard2.0 version uses the netstandard1.6 version of this library, this meansSIL.WritingSystems
includes references to Icu.SortKey (here). When an App (or Tests) targets net8.0 and adds an explicit reference toicu.net
(required for the config file), the app gets the net8.0 version of ICU, this version does not include theIcu.SortKey
class. This means when trying to callIcuRulesCollator.GetSortKey
you will get the following error at runtime:This could probably be solved by always including SortKey, however I don't see the need to support netstandard1.6. netstandard2.0 drops support for .net core 1.0 and 1.1, Mono 4.6, and a couple old Xamarin versions. See table here
This change is related to sillsdev/libpalaso#1330 and sillsdev/liblcm#306