Skip to content

Conversation

@TaperChipmunk32
Copy link
Collaborator

@TaperChipmunk32 TaperChipmunk32 commented Oct 27, 2025

  • Can now onboard multiple projects
  • --copy-from now will use the user's Downloads folder if included with no value
  • clean_project changed from silnlp.scripts.clean_project to silnlp.common.clean_projects so multiple projects can be cleaned at once and more unnecessary files are removed
  • Added a wildebeest section to the config, and default args for wildebeest analysis

This change is Reviewable

-Can now onboard multiple projects
- --copy-from now will use the user's Downloads folder if included with no value
-clean_project changed from silnlp.scripts.clean_project to silnlp.common.clean_projects so multiple projects can be cleaned at once and more unncessary files are removed
-Added a wildebeest section to the config, and default args for wildebeest analysis
@TaperChipmunk32 TaperChipmunk32 changed the title Made several improvements to onboard_project Improvements to onboard_project Oct 27, 2025
Copy link
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminking reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mmartin9684-sil)


silnlp/common/onboard_project.py line 170 at r1 (raw file):

        "--wildebeest", default=False, action="store_true", help="Run Wildebeest analysis on the extracted corpora."
    )
    parser.add_argument(

How does this work when the user passes multiple projects? Can they pass multiple zip files with different passwords?


silnlp/common/onboard_project.py line 200 at r1 (raw file):

                if needs_password:
                    if args.zip_password:
                        pwd = args.zip_password

I'm guessing that this change was driven by a request from the EITL team, but I liked prompting the user for the passwords, to help keep passwords out of the command history. But if EITL requested it to work this way, we should go with that.

Copy link
Collaborator Author

@TaperChipmunk32 TaperChipmunk32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @benjaminking and @mmartin9684-sil)


silnlp/common/onboard_project.py line 170 at r1 (raw file):

Previously, benjaminking (Ben King) wrote…

How does this work when the user passes multiple projects? Can they pass multiple zip files with different passwords?

No, it would not work. I have changed this to instead use a zip_password section in the config. The config would look something like this:

Code snippet:

zip_password:
    project_name_1: password_1
    project_name_2: password_2

silnlp/common/onboard_project.py line 200 at r1 (raw file):

Previously, benjaminking (Ben King) wrote…

I'm guessing that this change was driven by a request from the EITL team, but I liked prompting the user for the passwords, to help keep passwords out of the command history. But if EITL requested it to work this way, we should go with that.

Yes, because the script may take some time to run, it would be inconvenient to have to watch for any password prompts.

Copy link
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@benjaminking reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mmartin9684-sil)


silnlp/common/onboard_project.py line 170 at r1 (raw file):

Previously, TaperChipmunk32 (Matthew Beech) wrote…

No, it would not work. I have changed this to instead use a zip_password section in the config. The config would look something like this:

I like this solution.

@TaperChipmunk32 TaperChipmunk32 merged commit 3c419e8 into master Oct 28, 2025
1 check passed
@TaperChipmunk32 TaperChipmunk32 deleted the onboarding-imp branch October 28, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants