Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create improved book toggling component #2680

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Aug 21, 2024

This is a proposed component for toggling a book when selecting books (an alternative to mat chips).

I'm opening it as a draft PR so Storybook will get published to Chromatic.

I'm proposing a design, and I think this branch can serve as a basis if others want to propose a different design, by using this as a starting point.

For option A (what this PR originally had), see this storybook:
https://644bffe327c540a62f0fd260-wvwluxllwf.chromatic.com/?path=/story/translate-togglebook--selected


This change is Reviewable

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 24.24242% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.28%. Comparing base (7e91fbc) to head (1a80a2f).
Report is 2 commits behind head on master.

Files Patch % Lines
...ft-generation/toggle-book/toggle-book.component.ts 24.24% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2680      +/-   ##
==========================================
- Coverage   78.34%   78.28%   -0.06%     
==========================================
  Files         521      522       +1     
  Lines       30154    30187      +33     
  Branches     4930     4926       -4     
==========================================
+ Hits        23625    23633       +8     
- Misses       5755     5792      +37     
+ Partials      774      762      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami
Copy link
Collaborator Author

Nateowami commented Aug 22, 2024

See feature/book-toggle-no-border for another option:

EDIT: I've pushed that option to this PR.

@Nateowami Nateowami force-pushed the feature/book-toggle branch 3 times, most recently from 24adb93 to 8ee984a Compare August 22, 2024 20:34
@kylebuss
Copy link
Collaborator

My vote would be the book toggle with no border. I really like the info display of book completion percentage when hovering over the book!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants