Skip to content

Conversation

pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jul 1, 2025

This PR fixes a bug where "id" translations are defined as being in the "ıd" language code when a user whose language is Azerbaijani performs a sync.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jul 1, 2025
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.50%. Comparing base (9392541) to head (ef2156c).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3295   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         605      605           
  Lines       35204    35193   -11     
  Branches     5702     5700    -2     
=======================================
- Hits        29044    29036    -8     
+ Misses       5316     5315    -1     
+ Partials      844      842    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nateowami
Copy link
Collaborator

Can we try to replace all uses of ToLower with ToLowerInvariant throughout the application?

@pmachapman
Copy link
Collaborator Author

Can we try to replace all uses of ToLower with ToLowerInvariant throughout the application?

Good idea - Done. I found another case of this bug (although even more obscure) for Avatars, and fixed the MD5 function which was not correctly handling Unicode, and was using a slower, older method of hashing.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to see the original issue with biblical terms. Thanks for the work and the update to the MD5 hashing.

Reviewed 2 of 2 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@RaymondLuong3 RaymondLuong3 self-assigned this Jul 3, 2025
@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jul 3, 2025
@RaymondLuong3 RaymondLuong3 merged commit 8825ab0 into master Jul 4, 2025
17 of 18 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3453 branch July 4, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants