-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add dialog to show Serval build info #3527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive build information display for Serval-generated drafts by integrating raw engine and build data from Serval into a new tabbed dialog interface. The changes enable administrators to view detailed job information including build status, language pairs, training metrics, and event timelines.
Key Changes:
- Added backend API endpoints to retrieve raw engine and build data from Serval
- Replaced the events-only dialog with a comprehensive job details dialog featuring tabbed navigation
- Enhanced the draft jobs interface to show build details via clickable links instead of separate buttons
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| MachineApiService.cs | Added GetRawEngineAsync method to retrieve raw engine data from Serval |
| IMachineApiService.cs | Added interface definition for new GetRawEngineAsync method |
| MachineApi.cs | Added route constant for raw engine endpoint |
| MachineApiController.cs | Added controller endpoint to handle raw engine requests |
| draft-generation.service.ts | Added getRawEngine method to fetch engine data from backend |
| job-events-dialog.component.* | Removed old events-only dialog component files |
| job-details-dialog.component.* | Created new comprehensive dialog with build info and events tabs |
| draft-jobs.component.* | Updated to track additional events and open new job details dialog |
| material-styles.scss | Updated theme imports to reference new dialog component |
| _job-details-dialog-theme.scss | Added styling variables for new job details dialog |
| _draft-jobs-theme.scss | Added disabled link color variable |
| sf-project.service.ts | Renamed and refactored method to accept event types as parameter |
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-jobs.component.ts
Show resolved
Hide resolved
...IL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.service.ts
Show resolved
Hide resolved
...SIL.XForge.Scripture/ClientApp/src/app/serval-administration/job-details-dialog.component.ts
Show resolved
Hide resolved
0f80343 to
fb8b87b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
- Coverage 82.47% 82.22% -0.26%
==========================================
Files 615 615
Lines 36937 37053 +116
Branches 6014 6059 +45
==========================================
+ Hits 30464 30465 +1
- Misses 5586 5688 +102
- Partials 887 900 +13 ☔ View full report in Codecov by Sentry. |
533f4ae to
e326413
Compare
e326413 to
adf892e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmachapman reviewed 14 of 19 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
Most changes were made by Copilot
The draft jobs table has been cleaned up a bit. The dialog has been completely replaced with a lot more diagnostics.
Before
After
Events and build diagnostics are now both contained in a single dialog. The table now takes up slightly fewer columns, making wrapping less of an issue.
New dialog
Build details
Events list
This change is