Skip to content

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Oct 20, 2025

Most changes were made by Copilot

The draft jobs table has been cleaned up a bit. The dialog has been completely replaced with a lot more diagnostics.

Before

Screenshot from 2025-10-20 18-30-25

After

Screenshot from 2025-10-20 18-23-30

Events and build diagnostics are now both contained in a single dialog. The table now takes up slightly fewer columns, making wrapping less of an issue.

New dialog

Build details

Screenshot from 2025-10-20 18-29-17

Events list

Screenshot from 2025-10-20 18-29-28

This change is Reviewable

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive build information display for Serval-generated drafts by integrating raw engine and build data from Serval into a new tabbed dialog interface. The changes enable administrators to view detailed job information including build status, language pairs, training metrics, and event timelines.

Key Changes:

  • Added backend API endpoints to retrieve raw engine and build data from Serval
  • Replaced the events-only dialog with a comprehensive job details dialog featuring tabbed navigation
  • Enhanced the draft jobs interface to show build details via clickable links instead of separate buttons

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
MachineApiService.cs Added GetRawEngineAsync method to retrieve raw engine data from Serval
IMachineApiService.cs Added interface definition for new GetRawEngineAsync method
MachineApi.cs Added route constant for raw engine endpoint
MachineApiController.cs Added controller endpoint to handle raw engine requests
draft-generation.service.ts Added getRawEngine method to fetch engine data from backend
job-events-dialog.component.* Removed old events-only dialog component files
job-details-dialog.component.* Created new comprehensive dialog with build info and events tabs
draft-jobs.component.* Updated to track additional events and open new job details dialog
material-styles.scss Updated theme imports to reference new dialog component
_job-details-dialog-theme.scss Added styling variables for new job details dialog
_draft-jobs-theme.scss Added disabled link color variable
sf-project.service.ts Renamed and refactored method to accept event types as parameter

@Nateowami Nateowami force-pushed the feature/show-serval-draft-job-details branch from 0f80343 to fb8b87b Compare October 20, 2025 22:27
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 3.47222% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (bca9070) to head (adf892e).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...val-administration/job-details-dialog.component.ts 2.89% 67 Missing ⚠️
.../app/serval-administration/draft-jobs.component.ts 3.12% 31 Missing ⚠️
...orge.Scripture/Controllers/MachineApiController.cs 0.00% 22 Missing ⚠️
...SIL.XForge.Scripture/Services/MachineApiService.cs 0.00% 13 Missing ⚠️
...slate/draft-generation/draft-generation.service.ts 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3527      +/-   ##
==========================================
- Coverage   82.47%   82.22%   -0.26%     
==========================================
  Files         615      615              
  Lines       36937    37053     +116     
  Branches     6014     6059      +45     
==========================================
+ Hits        30464    30465       +1     
- Misses       5586     5688     +102     
- Partials      887      900      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami force-pushed the feature/show-serval-draft-job-details branch 2 times, most recently from 533f4ae to e326413 Compare October 20, 2025 23:02
@pmachapman pmachapman self-requested a review October 27, 2025 21:15
@pmachapman pmachapman self-assigned this Oct 27, 2025
@pmachapman pmachapman force-pushed the feature/show-serval-draft-job-details branch from e326413 to adf892e Compare October 27, 2025 21:16
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 14 of 19 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@pmachapman pmachapman merged commit 99001d5 into master Oct 27, 2025
23 checks passed
@pmachapman pmachapman deleted the feature/show-serval-draft-job-details branch October 27, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants