Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Oct 22, 2025

This PR allows Administrators who do not have all access to books on a project to add drafts to it for books not currently in that project.

I have marked this PR as testing not required, as it is backend only, but if you want to test the change yourself, use the branch feature/SF-3567-frontend, which I have wired up to test this code (in a very basic manner).

An e2e test is sufficient for the changes to the sync runner, as these will only be triggered if a project has books created in SF not in PT.


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 94.94949% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.50%. Comparing base (bca9070) to head (9e74fba).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/SIL.XForge.Scripture/Services/ParatextService.cs 92.95% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3528      +/-   ##
==========================================
+ Coverage   82.47%   82.50%   +0.03%     
==========================================
  Files         615      615              
  Lines       36937    37026      +89     
  Branches     6014     6050      +36     
==========================================
+ Hits        30464    30549      +85     
+ Misses       5586     5573      -13     
- Partials      887      904      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman changed the title WIP: SF-3618 Write permissions for new books on sync SF-3618 Write permissions for new books on sync Oct 22, 2025
@pmachapman pmachapman marked this pull request as ready for review October 22, 2025 01:54
@pmachapman pmachapman added the e2e Run e2e tests for this pull request label Oct 22, 2025
@pmachapman pmachapman removed the e2e Run e2e tests for this pull request label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant