Skip to content

Conversation

@RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Oct 22, 2025

This PR updates the behaviour on the draft formatting page so only chapters with drafts can be navigated to. Additionally, in the event that the user navigates to a chapter that when the draft cannot be accessed, the page will communicate that the chapter does not contain a draft rather than the cryptic "book does not exist" message.

image

This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Oct 22, 2025
@RaymondLuong3 RaymondLuong3 marked this pull request as draft October 22, 2025 22:03
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.20%. Comparing base (6c0ebdf) to head (36d47e5).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n/draft-usfm-format/draft-usfm-format.component.ts 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3532      +/-   ##
==========================================
- Coverage   82.21%   82.20%   -0.02%     
==========================================
  Files         615      615              
  Lines       37015    37013       -2     
  Branches     6060     6059       -1     
==========================================
- Hits        30433    30425       -8     
- Misses       5678     5682       +4     
- Partials      904      906       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 force-pushed the fix/sf-3601-empty-chapter branch from 707ad39 to 70af2f3 Compare October 30, 2025 16:30
@RaymondLuong3 RaymondLuong3 marked this pull request as ready for review October 30, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants