-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Create workflow #1
Conversation
c8bd035
to
ab6c140
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense for the setup steps in the test
job ("Configure PHP", "Apt install additional requirements ", "Configure apache - endtoend test") to be included as separate .sh
files which can just be executed from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to check "request changes"
4d10a0c
to
f703bee
Compare
b3fa69a
to
ae68d10
Compare
4f98310
to
d45c40a
Compare
.github/workflows/ci.yml
Outdated
run: | | ||
# apache2 is installed and running by default in ubuntu | ||
# update dir.conf to use index.php as the primary index doc | ||
cat << EOF > __dir.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this small change. If this syntax still doesn't work for some reason I'll concede it's not worth worrying about.
Issue silverstripe/github-actions-ci-cd#36