ENH Add generic types #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/2/add-generics
branch
2 times, most recently
from
13d9664
to
be183ae
Compare
emteknetnz
requested changes
Jan 18, 2024
src/Control/LDAPDebugController.php
Outdated
Comment on lines
22
to
23
| * @template T of SiteTree | ||
| * @extends ContentController<T> |
There was a problem hiding this comment.
Suggested change
| * @template T of SiteTree | |
| * @extends ContentController<T> | |
| * @extends ContentController<SiteTree> |
You'll also need to import SiteTree
I haven't consistently checked that things like SiteTree, DataObject etc have been imported for use in docblocks, you should probably spin off a new card to validate docblock imports
There was a problem hiding this comment.
I had this extensible so people can subclass it with their own type - but that's probably unlikely enough that making the suggested change is fine.
Done
There was a problem hiding this comment.
I haven't consistently checked that things like SiteTree, DataObject etc have been imported for use in docblocks, you should probably spin off a new card to validate docblock imports
I've added this as an AC for silverstripe/.github#181
GuySartorelli
force-pushed
the
pulls/2/add-generics
branch
from
be183ae
to
f22e75e
Compare
emteknetnz
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 and the corresponding silverstripe/cms PR for these generics to take effect.
Issue