Merge pull request #219 from creative-commoners/pulls/3/phpunit11

DEP Use PHPUnit 11
silverstripe · Sep 18, 2024 · 9e1e43d · 9e1e43d
2 parents 32a48a4 + f829e58
commit 9e1e43d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -30,7 +30,7 @@
         "ua-parser/uap-php": "^3.9.14"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.6",
+        "phpunit/phpunit": "^11.3",
         "squizlabs/php_codesniffer": "^3.7",
         "symbiote/silverstripe-queuedjobs": "^6",
         "silverstripe/standards": "^1",

diff --git a/tests/php/Control/LoginSessionControllerTest.php b/tests/php/Control/LoginSessionControllerTest.php
@@ -17,6 +17,7 @@
 use SilverStripe\SessionManager\Control\LoginSessionMiddleware;
 use SilverStripe\SessionManager\Controllers\LoginSessionController;
 use SilverStripe\SessionManager\Models\LoginSession;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class LoginSessionControllerTest extends FunctionalTest
 {
@@ -113,7 +114,7 @@ public function testBadSecurityID()
         );
     }
 
-    public function badIDs()
+    public static function badIDs()
     {
         return [
             'No ID' => [''],
@@ -123,8 +124,8 @@ public function badIDs()
 
     /**
      * @param $id
-     * @dataProvider badIDs
      */
+    #[DataProvider('badIDs')]
     public function testBadID($sessionID)
     {
         $token = SecurityToken::inst()->getValue();