Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Use new RememberLoginHash::onAfterRenewSession extension point #214

Open
wants to merge 1 commit into
base: 3
Choose a base branch
from

Conversation

Cheddam
Copy link
Member

@Cheddam Cheddam commented Aug 30, 2024

Description

This extension point is triggered at the same step as the now-removed onAfterRenewToken extension point, which was replaced to reflect that the token is no longer rotated when a session renewal is triggered.

I've also added some comments to more clearly articulate the session identifier replacement logic - I considered pulling this out instead, but for efficiency it makes sense to retain.

Co-dependent on related framework PR: silverstripe/silverstripe-framework#11355

Manual testing steps

Checkout this PR along with the Framework PR and validate that remember me functionality is intact.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

This extension point is triggered at the same step as the now-removed
onAfterRenewToken extension point, which was replaced to reflect that
the token is no longer rotated when a session renewal is triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant