Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better resiliance of bift on bad data #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

better resiliance of bift on bad data #59

wants to merge 2 commits into from

Conversation

kif
Copy link
Member

@kif kif commented Oct 21, 2021

tested on unsubtratedd SANS data

tested on unsubtratedd SANS data
@maaeli
Copy link
Contributor

maaeli commented Oct 22, 2021

Would it be possible to add the SANS data to the test data? Might be worth making a more permanent test out of it...

@kif
Copy link
Member Author

kif commented Oct 22, 2021

I am in contact with Anne to get access to those data. Apparently, the test dataset was not background corrected thus the crash.
Overall, it is better to make it resilient to those crashes.

@kif
Copy link
Member Author

kif commented Nov 12, 2021

This turns out to be not that simple ...

  • either one rebins SANS data to regular and fine qbins and fall back on the SAXS analysis
  • or one has to restart with I(q) = sum P(r)*sinc(qr) dr and re-implement them BIFT ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants