Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for H5Node soft link to an external link bug #3220

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Oct 13, 2020

Just adds a test that is expected to fail. Does not solve #3219. Upstream problem: h5py/h5py#1706

@t20100
Copy link
Member

t20100 commented Dec 11, 2023

@woutdenolf what is the status of this PR? Did it evolved in the meantime?

PR #3991 formatted the repo with black, so if this PR is still needed, you'll have to fix the conflicts.

@woutdenolf woutdenolf changed the title WIP: fix H5Node soft link to an external link Add test for H5Node soft link to an external link bug Dec 11, 2023
@woutdenolf woutdenolf marked this pull request as ready for review December 11, 2023 16:25
@woutdenolf woutdenolf requested a review from t20100 December 11, 2023 16:25
@woutdenolf
Copy link
Contributor Author

Rebased.

The problem is this: h5py/h5py#1706

Maybe we can merge this with just the test, not a fix?

@t20100 t20100 added this to the 2.0.0 milestone Dec 12, 2023
@t20100 t20100 merged commit 7fc5486 into silx-kit:main Dec 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants