Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.gui: Fixed QMouseEvent.globalPos() not available with PyQt6 #3989

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Dec 8, 2023

QMouseEvent.globalPos is deprecated in Qt6 and removed from PyQt6.

@t20100 t20100 added this to the 2.0.0 milestone Dec 8, 2023
@t20100 t20100 requested a review from vasole December 8, 2023 15:56
Copy link
Member

@vasole vasole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is strange that globalPos is kept in QContextMenuEvent

@vasole vasole merged commit fcb2711 into silx-kit:main Dec 8, 2023
7 checks passed
@t20100 t20100 deleted the fix-pyqt6 branch December 8, 2023 16:23
@t20100
Copy link
Member Author

t20100 commented Dec 8, 2023

Yes... and QMouseEvent.pos() is deprecated in Qt6 but still available in pyqt6 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants