ci: skip auto-release when a merge is marked [no-release] - #127
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesMatter bridge integration
Release metadata controls
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant BridgeProcess
participant LaunchAgent
participant MatterBridgeNode
BridgeProcess->>LaunchAgent: Install bridge package and plist
LaunchAgent->>MatterBridgeNode: Launch configured entrypoint
BridgeProcess->>MatterBridgeNode: Pass storage, port, and mDNS settings
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
tests/test_bridge_agent.py (1)
103-103: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueFix the capitalization in the test name.
test_storage_is_the_siblING_of_the_controllerscontains stray capitals. Every other test in this file uses lower-case words with deliberate emphasis only on whole words such asBEFORE. Rename it totest_storage_is_the_sibling_of_the_controllers.♻️ Proposed rename
-def test_storage_is_the_siblING_of_the_controllers(tmp_path, mock_logger): +def test_storage_is_the_sibling_of_the_controllers(tmp_path, mock_logger):🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/test_bridge_agent.py` at line 103, Rename the test function test_storage_is_the_siblING_of_the_controllers to test_storage_is_the_sibling_of_the_controllers, preserving the test implementation unchanged.tests/test_pairing_menu.py (1)
570-573: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMake the
BridgeProcessstand-in tolerant of the real call shape.
_factoryaccepts exactly two positional arguments.bridge_agent.BridgeProcess.__init__also accepts the keyword-only argumentshome,npx_path,runner,existsandsleep. If_start_bridge_agentpasses any of them,_factoryraisesTypeErrorand the test fails for a reason unrelated to the prefs snapshot it verifies. Every other monkeypatch in this class already uses*_a, **_k.♻️ Proposed change
- def _factory(prefs, _logger): + def _factory(prefs, _logger=None, **_kwargs): built.append(dict(prefs)) return Mock(ensure_installed=Mock(return_value=True), ws_port="5581", matter_port="5540")🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/test_pairing_menu.py` around lines 570 - 573, Update the local _factory stand-in in the pairing menu test to accept arbitrary additional positional and keyword arguments, matching the tolerant signatures used by the other monkeypatches. Preserve its existing prefs snapshot and Mock return behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/test_bridge_agent.py`:
- Line 103: Rename the test function
test_storage_is_the_siblING_of_the_controllers to
test_storage_is_the_sibling_of_the_controllers, preserving the test
implementation unchanged.
In `@tests/test_pairing_menu.py`:
- Around line 570-573: Update the local _factory stand-in in the pairing menu
test to accept arbitrary additional positional and keyword arguments, matching
the tolerant signatures used by the other monkeypatches. Preserve its existing
prefs snapshot and Mock return behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 7486053f-2635-4bda-8995-c0cc7b1b6486
📒 Files selected for processing (6)
.github/workflows/create-release.ymlindigo-matter.indigoPlugin/Contents/Info.plistindigo-matter.indigoPlugin/Contents/Server Plugin/bridge_agent.pytests/test_bridge_agent.pytests/test_export_agent_wiring.pytests/test_pairing_menu.py
Every merge to main currently mints a GitHub release, so a multi-PR feature arc produces a string of releases nobody installs — seven of them during the Matter export build, since deleted. The create-release job now skips when the head commit message contains [no-release]. GitHub's default merge commit is 'Merge pull request #N from ...' followed by the PR title, so the marker goes in the PR title. version-check is deliberately unaffected: every PR still needs its own PluginVersion bump, whether or not it releases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JxqGhP3DcENf68AZK21U4S
8d576b0 to
1ac05b5
Compare
1 participant
Summary
Every merge to
mainmints a GitHub release. During the Matter export build that produced seven releases nobody installs (now deleted). This adds an opt-out.create-releasejob gainsif: ${{ !contains(github.event.head_commit.message, '[no-release]') }}Merge pull request #N from …followed by the PR title, which is what the job readsversion-checkis deliberately untouched: every PR still needs a PluginVersion bump whether or not it releasesThis PR's own title carries the marker, so merging it is also its own test: if the change works, no release is created for it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JxqGhP3DcENf68AZK21U4S
Summary by CodeRabbit
New Features
Bug Fixes