Skip to content

Conversation

@Jaapp-
Copy link

@Jaapp- Jaapp- commented Feb 23, 2022

In Starlette, I'm using something like this:

auth_app = GitHubAuth(...)
app.mount('/admin', app=auth_app)

In this case, scope["path"] == "/" and scope["root_path"] == "/admin".
As a result the redirect cookie becomes /, but I'd like it to redirect to /admin/ instead.

This PR fixes that by prefixing the redirect path with scope["root_path"].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant