Distribute NFT child tokens with burning the qty=1 parent ones#3
Open
zh wants to merge 2 commits intosimpleledger:masterfrom
Open
Distribute NFT child tokens with burning the qty=1 parent ones#3zh wants to merge 2 commits intosimpleledger:masterfrom
zh wants to merge 2 commits intosimpleledger:masterfrom
Conversation
Closed
Member
|
@jcramer I have this running and seems to work here fine + looked this over. Wanna take a second look at it? |
Contributor
|
@blockparty-sh Does this PR have any updates you've found necessary for the waifufaucet? I don't have time to test this out so I'll let you merge it when its ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code from PR #2 require too many changes. The branch will be closed and the current one will replace it.
The goals for this PR:
server.ts- just one function change to point to a wrapper function generating NFTs and usual tokensslpfaucet.ts- a small wrapper function -tokenSend()server.ts- should be unaware what kind of tokens are distributedfaucet_utils.tscontains all NFT related code (in fact just one function)The faucet is working as it is now. As a future performance optimization (in a separate PR maybe) will try to combine creating single quantity parent token UTXO and NFT child token genesis in one call to the blockchain.