Bump simplesamlphp/simplesamlphp-test-framework from 1.9.3 to 1.10.0 in the all-actions group

.github/workflows/documentation.yml

@@ -18,7 +18,7 @@ jobs:
     runs-on: [ubuntu-latest]
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Lint markdown files
         uses: nosborn/github-action-markdown-cli@v3

.github/workflows/php.yml

@@ -19,9 +19,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-version: ['8.1', '8.2', '8.3', '8.4']
+        php-version: ['8.2', '8.3', '8.4']
 
-    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml@v1.9.3
+    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml@v1.10.0
     with:
       php-version: ${{ matrix.php-version }}
 
@@ -30,7 +30,7 @@ jobs:
     strategy:
       fail-fast: false
 
-    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml@v1.9.3
+    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml@v1.10.0
     with:
       enable_eslinter: false
       enable_jsonlinter: true
@@ -45,7 +45,7 @@ jobs:
       fail-fast: false
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['8.1', '8.2', '8.3', '8.4']
+        php-versions: ['8.2', '8.3', '8.4']
 
     steps:
       - name: Setup PHP, with composer and extensions
@@ -69,7 +69,7 @@ jobs:
           git config --global core.autocrlf false
           git config --global core.eol lf
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Get composer cache directory
         run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"
@@ -107,15 +107,15 @@ jobs:
       fail-fast: true
       matrix:
         operating-system: [windows-latest]
-        php-versions: ['8.1', '8.2', '8.3', '8.4']
+        php-versions: ['8.2', '8.3', '8.4']
 
     steps:
       - name: Setup PHP, with composer and extensions
         # https://github.com/shivammathur/setup-php
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php-versions }}
-          extensions: ctype, date, dom, fileinfo, filter, hash, intl, mbstring, openssl, pcre, posix, spl, xml
+          extensions: ctype, date, dom, fileinfo, filter, hash, intl, mbstring, openssl, pcre, posix, spl, xml, zip
           tools: composer
           ini-values: error_reporting=E_ALL
           coverage: none
@@ -131,7 +131,7 @@ jobs:
           git config --global core.autocrlf false
           git config --global core.eol lf
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Get composer cache directory
         run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$env:GITHUB_ENV"
@@ -168,7 +168,7 @@ jobs:
       - name: Setup problem matchers for PHP
         run: echo "::add-matcher::${{ runner.tool_cache }}/php.json"
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Get composer cache directory
         run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"
@@ -190,7 +190,9 @@ jobs:
         run: composer-require-checker check --config-file=tools/composer-require-checker.json composer.json
 
       - name: Check code for unused dependencies in composer.json
-        run: composer-unused
+        run: |
+          composer-unused \
+          --excludePackage=simplesamlphp/simplesamlphp-assets-jquery
 
       - name: PHP Code Sniffer
         run: phpcs
@@ -226,15 +228,15 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           # Should be the lowest supported version
-          php-version: '8.1'
+          php-version: '8.2'
           extensions: ctype, date, dom, fileinfo, filter, hash, intl, mbstring, openssl, pcre, posix, spl, xml
           tools: composer
           coverage: none
 
       - name: Setup problem matchers for PHP
         run: echo "::add-matcher::${{ runner.tool_cache }}/php.json"
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Get composer cache directory
         run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"
@@ -263,9 +265,9 @@ jobs:
     runs-on: [ubuntu-latest]
     needs: [unit-tests-linux]
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v5
         with:
           name: coverage-data
           path: ${{ github.workspace }}/build

src/Controller/MetaEditor.php

@@ -5,12 +5,12 @@
 namespace SimpleSAML\Module\metaedit\Controller;
 
 use Exception;
-use SimpleSAML\SAML2\Constants as C;
 use SimpleSAML\Auth;
 use SimpleSAML\Configuration;
 use SimpleSAML\Error;
 use SimpleSAML\Metadata;
 use SimpleSAML\Module\metaedit\MetaEditor as Editor;
+use SimpleSAML\SAML2\Constants as C;
 use SimpleSAML\Session;
 use SimpleSAML\Utils;
 use SimpleSAML\XHTML\Template;
@@ -26,7 +26,7 @@
  *
  * @package simplesamlphp/simplesamlphp-module-metaedit
  */
 class MetaEditor
 {
     /** @var \SimpleSAML\Configuration */
     protected Configuration $config;
@@ -101,10 +101,10 @@
             $this->moduleConfig->getOptionalArray('metahandlerConfig', ['directory' => '']),
         );
 
         $delete = $request->get('delete');
         if ($delete !== null) {
             $premetadata = $mdh->getMetadata($delete, 'saml20-sp-remote');
             $this->requireOwnership($premetadata, $userid);
             $mdh->deleteMetadata($delete, 'saml20-sp-remote');
         }
 
@@ -151,25 +151,25 @@
         }
         $userid = $attributes[$useridattr][0];
 
         $entityId = $request->get('entityid');
         $xmlMetadata = $request->get('xmlmetadata');
 
         $mdh = new Metadata\MetaDataStorageHandlerSerialize($this->moduleConfig->getArray('metahandlerConfig', []));
 
         if ($entityId !== null) {
             $metadata = $mdh->getMetadata($entityId, 'saml20-sp-remote');
             $this->requireOwnership($metadata, $userid);
         } elseif ($xmlMetadata !== null) {
             $xmlUtils = new Utils\XML();
             $xmlUtils->checkSAMLMessage($xmlMetadata, 'saml-meta');
             $entities = Metadata\SAMLParser::parseDescriptorsString($xmlMetadata);
             $entity = array_pop($entities);
             $metadata = $entity->getMetadata20SP();
 
             /* Trim metadata endpoint arrays. */
             $metadata['AssertionConsumerService'] = [
                 Utils\Config\Metadata::getDefaultEndpoint(
                     $metadata['AssertionConsumerService'],
                     [C::BINDING_HTTP_POST],
                 ),
             ];