Add CI to automate heavy PR load #3374
Open
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to sindresorhus#1365 Implement CI to automate heavy PR load using `awesome-lint`. * **.github/workflows/main.yml** - Add a step to run `awesome-lint` on `readme.md` after the checkout step. * **.github/workflows/repo_linter.sh** - Add `npx awesome-lint` command to lint the repository after cloning. * **readme.md** - Mention the usage of `awesome-lint` for CI in the introduction. - Add a section about `awesome-lint` in the "Contribution guide". * **contributing.md** - Add instructions for running `awesome-lint` before submitting a PR. - Mention the requirement to pass `awesome-lint` in the PR guidelines.
TrueAplhaSpiral
approved these changes
Mar 13, 2025
ankddev
reviewed
Mar 14, 2025
Comment on lines
20
to
+25
| git clone "$REPO_TO_LINT" . | ||
| npx awesome-lint | ||
| fi | ||
|
|
||
| # Lint the repository using awesome-lint | ||
| npx awesome-lint |
There was a problem hiding this comment.
But it already run awesome-lint in previous step, so I don't think that this is reliable change.
Comment on lines
+15
to
+16
| - name: Run awesome-lint on readme.md | ||
| run: npx awesome-lint readme.md |
There was a problem hiding this comment.
It runs repo_linter.sh so additional step with linting is unneded.
GLOBALGHOST21
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1365
Implement CI to automate heavy PR load using
awesome-lint.awesome-lintonreadme.mdafter the checkout step.npx awesome-lintcommand to lint the repository after cloning.awesome-lintfor CI in the introduction.awesome-lintin the "Contribution guide".awesome-lintbefore submitting a PR.awesome-lintin the PR guidelines.