Update index.d.ts to loosen type restriction on download #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -178,7 +179,7 @@ ipcMain.on('download-button', async (event, {url}) => { | |||
| ``` | |||
| */ | |||
| export function download( | |||
| window: BrowserWindow | BrowserView, | |||
| window: { webContents: Electron.WebContents }, | |||
There was a problem hiding this comment.
This has the downside of not making it clear to the user what they can pass in. Autocomplete is more important than flexibility here I think. So I prefer to just list the supported types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron has recently WebContentsView which is not included in the types expected by download. Since download only uses the webContents property, I suggest we loosen the type to anything that has that property. This would make it useful for anything that gets added in the futur too.