Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field exclusions test #111

Merged
merged 8 commits into from
Mar 26, 2025
Merged

Fix field exclusions test #111

merged 8 commits into from
Mar 26, 2025

Conversation

leslievandemark
Copy link
Collaborator

Description of change

A number of metrics and dimensions now fail the checkCompatibility data api request. Their compatibilities change based on what they are selected with. This pr sets their field_exclusions to an empty list so that users are not restricted when selecting them in a custom report. Users are encouraged to check selections against google's dimensions and metrics explorer

Manual QA steps

  • ran test_field_exclusions locally

Risks

  • low

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

kgerxhi and others added 8 commits February 27, 2025 19:13
-----------------------------

Co-authored-by: Leslie VanDeMark <[email protected]>
-----------------------------

Co-authored-by: Leslie VanDeMark <[email protected]>
-----------------------------

Co-authored-by: Leslie VanDeMark <[email protected]>
-----------------------------

Co-authored-by: Leslie VanDeMark <[email protected]>
-----------------------------

Co-authored-by: Leslie VanDeMark <[email protected]>
…#108

-----------------------------

Co-authored-by: Leslie VanDeMark <[email protected]>
-----------------------------

Co-authored-by: Leslie VanDeMark <[email protected]>
@leslievandemark leslievandemark merged commit 7b5b297 into main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants