Display score change in submissions admin#405
Draft
MasloMaslane wants to merge 3 commits intosio2project:masterfrom
Draft
Display score change in submissions admin#405MasloMaslane wants to merge 3 commits intosio2project:masterfrom
MasloMaslane wants to merge 3 commits intosio2project:masterfrom
Conversation
metenn
reviewed
Sep 16, 2024
Contributor
metenn
left a comment
There was a problem hiding this comment.
If I understand correctly, actions like changing the submission kind will also affect the score diff, which might yield unintended results?
I think you accidentally also formatted some existing test code, which, while objectively better, could be confusing for future git blame's and makes this PR's diff a bit harder to navigate
56ba98e to
fc02649
Compare
metenn
requested changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #350