Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/sinol_make/commands/chkwer/chkwer_util.py:62
- [nitpick] Instead of comparing result.stderr to an empty string, consider checking its truthiness (e.g., 'if result.stderr:') to handle potential None values or unexpected types more gracefully.
if result.stderr != "":
Comment on lines
22
to
+24
| try: | ||
| with open(compile_log_path, "w") as compile_log: | ||
| compile.compile(file_path, output, compile_log=compile_log, use_fsanitize=use_fsanitize) | ||
| compile.compile(file_path, output, compile_log=compile_log, use_sanitizers=use_fsanitize) |
There was a problem hiding this comment.
The 'use_fsanitize' variable is a boolean, but the new 'use_sanitizers' parameter is expected to be a string (e.g., 'no', 'simple', or 'full'). Consider converting the boolean to an appropriate string value (for example, use 'simple' if True, and 'no' if False).
MasloMaslane
force-pushed
the
sanitizers
branch
from
e722b99 to
e8bdff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.