Open
Conversation
otargowski
reviewed
Mar 24, 2026
MasloMaslane
force-pushed
the
box-scripts
branch
from
a0a546f to
7c4a4c4
Compare
otargowski
reviewed
Mar 25, 2026
Comment on lines
+73
to
+78
| # Remove mount points but keep /tmp and /dev (needed by sio2jail bind mounts) | ||
| sudo rm -rf "$chroot_dir/proc" | ||
| sudo rm -rf "$chroot_dir/sys" | ||
| sudo rm -rf "$chroot_dir/tmp" | ||
| sudo mkdir -p "$chroot_dir/proc" | ||
| sudo mkdir -p "$chroot_dir/tmp" | ||
| sudo mkdir -p "$chroot_dir/dev" |
Contributor
There was a problem hiding this comment.
Imho /tmp should be cleared before the mkdir, just as /proc is, as there may be some leftover files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.