feat: Improve tool call extraction and stripping to support multiple …#586
Open
RahulChand028 wants to merge 1 commit intosipeed:mainfrom
Open
feat: Improve tool call extraction and stripping to support multiple …#586RahulChand028 wants to merge 1 commit intosipeed:mainfrom
RahulChand028 wants to merge 1 commit intosipeed:mainfrom
Conversation
…blocks and markdown wrappers with robust JSON brace matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Harden the tool call extraction logic by implementing a robust, state-aware scanner and supporting complex model outputs.
Key Changes
findMatchingBracethat correctly handles nested objects, JSON strings, and escaped characters.json ...) and flexible JSON markers (e.g.,{ "tool_calls": ... }).nextToolCallBlockhelper to improve maintainability and performance.🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
I raised a fix earlier, but some unrelated changes were accidentally included while resolving conflicts. I’ve now created a new PR with the improvements and without those extra changes.
#497
📚 Technical Context (Skip for Docs)
🧪 Test Environment
📸 Evidence (Optional)
Details
☑️ Checklist