Conversation
xiaket
left a comment
There was a problem hiding this comment.
Instead of bringing the changes, do you mind bringing the tooling into this repo so we are not tripped by this issue again?
Also please provide a description of this PR so we can better keep track of changes. Thank you!
Please address the concern above and re-request review.
Signed-off-by: Александр Мелентьев <aleksandr4842@ya.ru>
|
@xiaket hello! Thank you for review. I added go fix check to CI |
|
@aleksandr4842 do you mind taking a look at the failed build? |
Signed-off-by: Александр Мелентьев <aleksandr4842@ya.ru>
|
@xiaket fixed |
|
Thanks for your contribution! CI part LGTM, but this PR also touches other areas (including agent and provider), so it still needs review from the other two developers(@yinwm , @lxowalle). (When merging with squash, please update the commit message header to follow this specification: https://www.conventionalcommits.org/en/v1.0.0/) |
|
Hi @aleksandr4842, I'm not sure if |
|
All changes in PR by go fix command |
It does look odd indeed. I ran My version info is:
|
|
I use go1.26. In this version go fix was changed... |
|
Thanks @aleksandr4842 ! In that case, we may want to close this PR and revisit at a later date, since the go version in |
📝 Description
Add check code by go fix
Fix code, and add this check to CI
🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
📚 Technical Context (Skip for Docs)
🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
☑️ Checklist