Skip to content

Comments

Add go fix check#589

Closed
aleksandr4842 wants to merge 3 commits intosipeed:mainfrom
aleksandr4842:gofix
Closed

Add go fix check#589
aleksandr4842 wants to merge 3 commits intosipeed:mainfrom
aleksandr4842:gofix

Conversation

@aleksandr4842
Copy link

@aleksandr4842 aleksandr4842 commented Feb 21, 2026

📝 Description

Add check code by go fix

Fix code, and add this check to CI

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

📚 Technical Context (Skip for Docs)

  • Reference URL:
  • Reasoning:

🧪 Test Environment

  • Hardware:
  • OS:
  • Model/Provider:
  • Channels:

📸 Evidence (Optional)

Click to view Logs/Screenshots

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@xiaket xiaket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of bringing the changes, do you mind bringing the tooling into this repo so we are not tripped by this issue again?

Also please provide a description of this PR so we can better keep track of changes. Thank you!

Please address the concern above and re-request review.

Signed-off-by: Александр Мелентьев <aleksandr4842@ya.ru>
@aleksandr4842 aleksandr4842 changed the title run go fix Add go fix check Feb 22, 2026
@aleksandr4842
Copy link
Author

@xiaket hello! Thank you for review. I added go fix check to CI

@aleksandr4842 aleksandr4842 requested a review from xiaket February 22, 2026 07:08
Copy link
Collaborator

@xiaket xiaket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait for a second round of eyes from @imguoguo before getting this in.

@xiaket xiaket requested a review from imguoguo February 22, 2026 07:24
@xiaket
Copy link
Collaborator

xiaket commented Feb 22, 2026

@aleksandr4842 do you mind taking a look at the failed build?

Signed-off-by: Александр Мелентьев <aleksandr4842@ya.ru>
@aleksandr4842
Copy link
Author

@xiaket fixed

@imguoguo imguoguo requested review from lxowalle and yinwm February 22, 2026 09:34
@imguoguo
Copy link
Member

Thanks for your contribution!

CI part LGTM, but this PR also touches other areas (including agent and provider), so it still needs review from the other two developers(@yinwm , @lxowalle).

(When merging with squash, please update the commit message header to follow this specification: https://www.conventionalcommits.org/en/v1.0.0/)

@lxowalle
Copy link
Collaborator

Hi @aleksandr4842, I'm not sure if go fix would change for i := 0; i < 5; i++ to for i := range 5 — my local tests show it doesn't. But this PR contains many similar changes. Can you confirm whether these changes were all made by go fix? Also, could we add go fix to the check command in the Makefile so developers can catch these issues earlier?

@aleksandr4842
Copy link
Author

All changes in PR by go fix command

@imguoguo
Copy link
Member

Hi @aleksandr4842, I'm not sure if go fix would change for i := 0; i < 5; i++ to for i := range 5 — my local tests show it doesn't. But this PR contains many similar changes. Can you confirm whether these changes were all made by go fix? Also, could we add go fix to the check command in the Makefile so developers can catch these issues earlier?

It does look odd indeed. I ran go fix ./... in the picoclaw directory on Fedora 43 with Go 1.25.7 at this commit(80c8b57), but it produced no changes. Is there something wrong with my operating method?

My version info is:

go version go1.25.7 X:nodwarf5 linux/amd64

@aleksandr4842
Copy link
Author

I use go1.26. In this version go fix was changed...

@xiaket
Copy link
Collaborator

xiaket commented Feb 22, 2026

Thanks @aleksandr4842 ! In that case, we may want to close this PR and revisit at a later date, since the go version in go.mod is still on 1.25.7.

@aleksandr4842 aleksandr4842 deleted the gofix branch February 23, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants