add pdb owner ref

six-group · Aug 29, 2024 · 46e1c30 · 46e1c30
1 parent e34113c
commit 46e1c30
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/controllers/instance/pod_disruption_budget.go b/controllers/instance/pod_disruption_budget.go
@@ -23,12 +23,11 @@ func (r *Reconciler) reconcilePDB(ctx context.Context, instance *proxyv1alpha1.I
 		},
 	}
 
-	if err := controllerutil.SetOwnerReference(instance, pdb, r.Scheme); err != nil {
-		return err
-	}
-
 	if instance.Spec.PodDisruptionBudget.MaxUnavailable != nil || instance.Spec.PodDisruptionBudget.MinAvailable != nil {
 		result, err := controllerutil.CreateOrUpdate(ctx, r.Client, pdb, func() error {
+			if err := controllerutil.SetOwnerReference(instance, pdb, r.Scheme); err != nil {
+				return err
+			}
 			pdb.Spec.Selector = metav1.SetAsLabelSelector(utils.GetPodLabels(instance))
 			pdb.Spec.MaxUnavailable = instance.Spec.PodDisruptionBudget.MaxUnavailable
 			pdb.Spec.MinAvailable = instance.Spec.PodDisruptionBudget.MinAvailable