Skip to content

chore(deps-dev): Bump brace-expansion from 1.1.12 to 1.1.13#428

Merged
sjnims merged 1 commit intomainfrom
dependabot/npm_and_yarn/brace-expansion-1.1.13
Mar 27, 2026
Merged

chore(deps-dev): Bump brace-expansion from 1.1.12 to 1.1.13#428
sjnims merged 1 commit intomainfrom
dependabot/npm_and_yarn/brace-expansion-1.1.13

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 27, 2026

Bumps brace-expansion from 1.1.12 to 1.1.13.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.12 to 1.1.13.
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v1.1.12...v1.1.13)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.13
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from sjnims as a code owner March 27, 2026 14:09
@dependabot dependabot bot added dependencies Pull requests that update a dependency file npm Pull requests that update npm dependencies labels Mar 27, 2026
@sjnims sjnims merged commit ffa14eb into main Mar 27, 2026
10 of 12 checks passed
@sjnims sjnims deleted the dependabot/npm_and_yarn/brace-expansion-1.1.13 branch March 27, 2026 20:35
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 27, 2026

CI Failure Analysis: CI

Run: #23666397460 | Commit: ffa14eb

Summary

Two jobs failed: Dead Code Check found 3 unused exported types, and Test passed all tests but crashed during coverage report generation due to a recursive directory copy (coveragecoverage/coverage).

Failures Found

Job File Issue
Dead Code Check src/stages/3-execution/sdk-client.ts:51 Unused exported type PermissionMode
Dead Code Check src/stages/3-execution/sdk-client.ts:72 Unused exported type SDKResultSuccess
Dead Code Check src/stages/3-execution/sdk-client.ts:72 Unused exported type SDKResultError
Test Vitest coverage reporter EINVAL: cannot copy coverage to a subdirectory of self coverage/coverage

How to Fix

Dead code (knip): Remove or mark as used the 3 unused exported types in sdk-client.ts. If they are part of the public API, add them to the knip ignore config:

# Option A: Remove unused exports
# Edit src/stages/3-execution/sdk-client.ts and remove PermissionMode, SDKResultSuccess, SDKResultError exports

# Option B: Run knip to verify
npx knip

Test coverage crash: The Vitest UI reporter is trying to copy coverage/ into coverage/coverage/, creating a self-referencing loop. This is likely caused by the coverage output directory (reportsDirectory) being set to coverage/ while the Vitest UI outputDir also resolves to or includes coverage/. Fix by ensuring the @vitest/ui reporter output directory does not overlap with the coverage directory:

// vitest.config.ts — ensure coverage output doesn't conflict with UI output
coverage: {
  reportsDirectory: './coverage',  // check this doesn't nest inside itself
}

Also check knip.json — the hints suggest removing dist/**, coverage/**, and node_modules/** from the ignore array (these are already ignored by default).


Analyzed by Claude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file npm Pull requests that update npm dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant