Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Parity #160

Draft
wants to merge 87 commits into
base: main
Choose a base branch
from
Draft

DRAFT: Parity #160

wants to merge 87 commits into from

Conversation

huntabyte
Copy link

EARLY DRAFT. STILL A TON TO DO.

For @Hugos68 SA

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
floating-ui-svelte ❌ Failed (Inspect) Jan 29, 2025 2:17am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 90751c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Hugos68
Hugos68 reviewed Jan 10, 2025
View reviewed changes
packages/floating-ui-svelte/src/hooks/use-position.svelte.ts Outdated
});
}

update = async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this not be a regular function? async update() { .... }, it saves some memory when creating loads of instances.

@Hugos68
Copy link
Collaborator

Hugos68 commented Jan 10, 2025

@huntabyte I merged main so that you have the updated Github Actions since they needed some love, you can ignore that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hugos68 Hugos68 Hugos68 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huntabyte @Hugos68