Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic README #31

Merged
merged 10 commits into from
May 2, 2024
Merged

Added basic README #31

merged 10 commits into from
May 2, 2024

Conversation

Hugos68
Copy link
Collaborator

@Hugos68 Hugos68 commented Apr 28, 2024

No description provided.

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
floating-ui-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 2:45pm

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated
| strategy | The type of CSS position property to use. | Strategy | 'absolute' |
| middleware | These are plain objects that modify the positioning coordinates in some fashion, or provide useful data for the consumer to use. | Array<Middleware \| undefined \| null \| false> | undefined |
| transform | Whether to use `transform` instead of `top` and `left` styles to position the floating element (`floatingStyles`). | boolean | true |
| elements | The reference and floating elements. | FloatingElements | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess The reference and floating elements. should be The reference **to the** floating elements. or just **The** floating elements.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the name of the variable speaks for itself, on top of the example above. Though I'll leave this open for others to comment about.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer The floating elements.

@Hugos68 Hugos68 merged commit b9b532d into dev May 2, 2024
7 checks passed
@Hugos68 Hugos68 deleted the feat/readme branch May 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants