Skip to content

Conversation

nicolas-guerrier
Copy link

Updating nginx.conf to switch fastcgi_intercept_errors parameter from on to off, so applications could catch the http code (most CMS would have custom handler for 40X errors)

Copy link
Member

@gaydabura gaydabura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change of error management should be overwrited on client side, but by default you may confuse developer if he will not see any errors anymore

@andypost
Copy link
Contributor

Checked https://github.com/wodby/php-nginx/blob/master/templates/fastcgi.conf.tpl#L33 the base where we did fork

basically it makes sense to allow configurable

@andypost
Copy link
Contributor

I think better to move fastcgi settings to own https://github.com/skilld-labs/skilld-docker-nginx/blob/master/11/fastcgi_params file which could be overriden for project specific settings

@andypost andypost force-pushed the forward-errors-to-app branch from 4767852 to 76aea48 Compare October 25, 2019 14:24
@andypost
Copy link
Contributor

I did rebase on top of latest code but still not sure it affects us

http://nginx.org/en/docs/http/ngx_http_fastcgi_module.html#fastcgi_intercept_errors
tells about 30x errors (not 40x)

@nicolas-guerrier
Copy link
Author

Determines whether FastCGI server responses with codes greater than or equal to 300 should be passed to a client or be intercepted and redirected to nginx for processing with the error_page directive.

This is about 300+ response codes, so that should still affect us for 40x errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants