test(web): automate the SPDX visual checks left to a human#419
Merged
Conversation
The 2026-07 Windows verification left three SPDX surfaces to a human eye: the SPDX chip on the results SBOM card, the chip addressing the .spdx.json artifact, and the Re-scan flow restoring the SPDX export toggle. Cover them with a stubbed-backend Playwright spec (mirroring rescan.spec.ts), and note in the verification procedure that these checks now run in CI, so Windows rounds only repeat them when a real browser look is wanted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The 2026-07 Windows verification round left three SPDX-related checks to a human eye (results doc, section 6): the SPDX chip appearing on the SBOM card, the chip actually addressing the
.spdx.jsonartifact, and "Re-scan with the same settings" restoring the SPDX export toggle. Human-only checks get skipped; these are all assertable.What
tests/ui/spdx.spec.ts: three specs with a fully stubbed backend (same pattern asrescan.spec.ts) — chip visibility, chiphrefcarrying the artifact name and run id, and the Re-scan prefill restoringspdx: true(withsecurity: falseasserted alongside to prove it's not a default).docs/maintainers/windows-verification.md: the procedure now notes these three checks run in CI, so Windows rounds repeat them only when a real-browser look is wanted.Server-side SPDX generation stays covered by
tests/test-web-ui.sh; this closes the UI-surface gap.Verification
playwright test tests/ui/spdx.spec.ts— 3/3 pass