Skip to content

fix(desktop): load logo assets via relative paths so the packaged app renders #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haksungjang merged 1 commit into from
Jul 14, 2026
Merged

fix(desktop): load logo assets via relative paths so the packaged app renders #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" type="image/svg+xml" href="favicon.svg" />
<title>onot — OSS Notice Generator</title>
</head>
<body>
Expand Down
18 changes: 0 additions & 18 deletions frontend/public/logo.svg
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion frontend/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { useState } from "react";
import logoMark from "./assets/logo-mark.svg";
import sampleSpdx from "./assets/example.spdx.json?raw";
import { FileDropzone } from "./components/FileDropzone";
import { Preview } from "./components/Preview";
Expand Down Expand Up @@ -112,7 +113,7 @@ export default function App() {
return (
<div className="mx-auto max-w-6xl p-6">
<header className="mb-6 flex items-center gap-3">
<img src="/logo-mark.svg" alt="onot" width={44} height={44} className="shrink-0" />
<img src={logoMark} alt="onot" width={44} height={44} className="shrink-0" />
<div>
<h1 className="text-2xl font-bold">{t(uiLang, "title")}</h1>
<p className="text-sm text-zinc-400">{t(uiLang, "subtitle")}</p>
Expand Down
0 frontend/public/logo-mark.svg → frontend/src/assets/logo-mark.svg
View file
Open in desktop
File renamed without changes
Loading