Repository navigation
Conversation
…etection The slackLists workflow test only created text/date/select/user columns without option variants, so the recorded slackLists.* samples never contained the options.precision (number), options.date_format (date), or options.emoji/options.max (rating) properties. Downstream, the node-slack-sdk generator therefore inferred a thinner SchemaOptions that dropped those fields. Add a number column (precision), give the date column a dateFormat, and add a rating column (emoji, max) to fullSlackListsWorkflow so the live response echoes these options back and the detection mechanism records them.
Member
Author
|
Re-targeting: this change belongs on the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
=========================================
Coverage 73.24% 73.24%
Complexity 4522 4522
=========================================
Files 478 478
Lines 14314 14314
Branches 1491 1491
=========================================
Hits 10484 10484
Misses 2940 2940
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends the Slack Lists remote-API test to create column types whose
optionssub-properties were never being recorded, so the automatic property-detection mechanism picks them up.Context
fullSlackListsWorkflowonly createdtext/date/select/usercolumns, and none set the option variants that Slack echoes back per column type. As a result the recordedslackLists.*samples never contained:options.precision(number columns)options.date_format(date columns with a format)options.emoji/options.max(rating columns)Downstream, the node-slack-sdk response-type generator infers types from these samples, so it produced a thinner
SchemaOptionsthat dropped those documented fields — a consumer-facing regression onslackLists.create/slackLists.items.info.Changes
due_datecolumn adateFormatoption → recordsdate_format.numbercolumn (estimate) withprecision→ recordsprecision.ratingcolumn (priority) withemojiandmax→ recordsemojiandmax.The
ListColumnOptionsmodel already supports all of these fields; this only exercises them.Category
Testing
workflow_dispatch), then confirm the regeneratedjson-logs/samples/api/slackLists.create.jsonnow containsoptions.precision,options.date_format,options.emoji, andoptions.max.Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.