Skip to content

test: exercise number/date/rating list columns for options property detection - #1631

Closed
zimeg wants to merge 1 commit into
mainfrom
zimeg-test-slacklists-column-detection
Closed

zimeg wants to merge 1 commit into
mainfrom
zimeg-test-slacklists-column-detection

Conversation

@zimeg

@zimeg zimeg commented Aug 19, 2026

Copy link
Copy Markdown
Member

This pull request extends the Slack Lists remote-API test to create column types whose options sub-properties were never being recorded, so the automatic property-detection mechanism picks them up.

Context

fullSlackListsWorkflow only created text / date / select / user columns, and none set the option variants that Slack echoes back per column type. As a result the recorded slackLists.* samples never contained:

  • options.precision (number columns)
  • options.date_format (date columns with a format)
  • options.emoji / options.max (rating columns)

Downstream, the node-slack-sdk response-type generator infers types from these samples, so it produced a thinner SchemaOptions that dropped those documented fields — a consumer-facing regression on slackLists.create / slackLists.items.info.

Changes

  • Give the existing due_date column a dateFormat option → records date_format.
  • Add a number column (estimate) with precision → records precision.
  • Add a rating column (priority) with emoji and max → records emoji and max.
  • Wire the new columns into the create-list schema.

The ListColumnOptions model already supports all of these fields; this only exercises them.

Category

  • slack-api-client (Slack API Clients)

Testing

  • Run the Slack Lists remote-API flow against a test workspace (via the java-slack-sdk-runner workflow_dispatch), then confirm the regenerated json-logs/samples/api/slackLists.create.json now contains options.precision, options.date_format, options.emoji, and options.max.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

…etection

The slackLists workflow test only created text/date/select/user columns
without option variants, so the recorded slackLists.* samples never
contained the options.precision (number), options.date_format (date),
or options.emoji/options.max (rating) properties. Downstream, the
node-slack-sdk generator therefore inferred a thinner SchemaOptions that
dropped those fields.

Add a number column (precision), give the date column a dateFormat, and
add a rating column (emoji, max) to fullSlackListsWorkflow so the live
response echoes these options back and the detection mechanism records
them.
@zimeg

zimeg commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

Re-targeting: this change belongs on the api branch (the runner's steady-state detection branch), not a fork branch off main. Reopening against api.

@zimeg zimeg closed this Aug 19, 2026
@zimeg
zimeg deleted the zimeg-test-slacklists-column-detection branch August 19, 2026 23:10
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.24%. Comparing base (3924704) to head (3d73ed7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1631   +/-   ##
=========================================
  Coverage     73.24%   73.24%           
  Complexity     4522     4522           
=========================================
  Files           478      478           
  Lines         14314    14314           
  Branches       1491     1491           
=========================================
  Hits          10484    10484           
  Misses         2940     2940           
  Partials        890      890           
Flag Coverage Δ
jdk-14 73.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant