Repository navigation
feat: add admin.apps.mcp.servers.permissions.set method - #1698
Merged
Merged
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
=======================================
Coverage ? 74.03%
Complexity ? 4757
=======================================
Files ? 487
Lines ? 14811
Branches ? 1536
=======================================
Hits ? 10965
Misses ? 2935
Partials ? 911
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This was referenced Nov 13, 2026
…test Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…-admin-apps-mcp-servers-permissions-list
…st response test Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…o zimeg-feat-admin-apps-mcp-servers-permissions-set
…t response test Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
changed the base branch from
zimeg-feat-admin-apps-mcp-servers-permissions-list
to
main
November 13, 2026 07:22
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
admin.apps.mcp.servers.permissions.setmethod to the sync and async clients.adminAppsMcpServersPermissionsSettakesappId,serverId,permissionType,userIds, andusergroupIds.user_idsandusergroup_idsare sent comma-joined, like other ID arrays in this SDK. The response has the updated server's fields, the same onespermissions.listreturns.AdminApiTestparses a response captured from the live API, and the test fails on any unknown property, so every returned field is typed.This is part 3 of 3 in a stack that adds the MCP server admin methods one at a time, so Slackbot skills can be built with MCP servers. Each pull request builds on the one before it and merges on its own, bottom to top.
admin.apps.mcp.servers.listadmin.apps.mcp.servers.permissions.listadmin.apps.mcp.servers.permissions.set👈 this pull requestTesting
Run the remote tests for this layer:
test_with_remote_apis.methods_admin_api.AdminApi_apps_mcp_servers_TestwithSLACK_SDK_TEST_GRID_ORG_ADMIN_USER_TOKEN(admin.apps:read,admin.apps:write)Each layer of this stack was checked against an Enterprise Grid developer sandbox by running every method added so far, in order. The
permissions.settest sets a permission and then restores the original.Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.
🤖 Generated with Claude Code