Skip to content

feat: add admin.apps.mcp.servers.permissions.set method - #1698

Merged
zimeg merged 9 commits into
mainfrom
zimeg-feat-admin-apps-mcp-servers-permissions-set
Nov 13, 2026
Merged

zimeg merged 9 commits into
mainfrom
zimeg-feat-admin-apps-mcp-servers-permissions-set

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

This pull request adds the admin.apps.mcp.servers.permissions.set method to the sync and async clients.

  • adminAppsMcpServersPermissionsSet takes appId, serverId, permissionType, userIds, and usergroupIds.
  • user_ids and usergroup_ids are sent comma-joined, like other ID arrays in this SDK. The response has the updated server's fields, the same ones permissions.list returns.
  • AdminApiTest parses a response captured from the live API, and the test fails on any unknown property, so every returned field is typed.

This is part 3 of 3 in a stack that adds the MCP server admin methods one at a time, so Slackbot skills can be built with MCP servers. Each pull request builds on the one before it and merges on its own, bottom to top.

  1. feat: add admin.apps.mcp.servers.list method #1696 admin.apps.mcp.servers.list
  2. feat: add admin.apps.mcp.servers.permissions.list method #1697 admin.apps.mcp.servers.permissions.list
  3. feat: add admin.apps.mcp.servers.permissions.set method #1698 admin.apps.mcp.servers.permissions.set 👈 this pull request

Testing

Run the remote tests for this layer:

  • test_with_remote_apis.methods_admin_api.AdminApi_apps_mcp_servers_Test with SLACK_SDK_TEST_GRID_ORG_ADMIN_USER_TOKEN (admin.apps:read, admin.apps:write)

Each layer of this stack was checked against an Enterprise Grid developer sandbox by running every method added so far, in order. The permissions.set test sets a permission and then restores the original.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

🤖 Generated with Claude Code

zimeg and others added 3 commits November 12, 2026 21:21
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 05:26
@zimeg zimeg added this to the 1.54.1 milestone Nov 13, 2026
@zimeg zimeg added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client semver:minor labels Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@621ac5e). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...java/com/slack/api/methods/RequestFormBuilder.java 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1698   +/-   ##
=======================================
  Coverage        ?   74.03%           
  Complexity      ?     4757           
=======================================
  Files           ?      487           
  Lines           ?    14811           
  Branches        ?     1536           
=======================================
  Hits            ?    10965           
  Misses          ?     2935           
  Partials        ?      911           
Flag Coverage Δ
jdk-14 74.03% <84.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

zimeg and others added 5 commits November 12, 2026 22:56
…test

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…st response test

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…o zimeg-feat-admin-apps-mcp-servers-permissions-set
…t response test

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg changed the base branch from zimeg-feat-admin-apps-mcp-servers-permissions-list to main November 13, 2026 07:22
@zimeg
zimeg merged commit b93c2d1 into main Nov 13, 2026
7 checks passed
@zimeg
zimeg deleted the zimeg-feat-admin-apps-mcp-servers-permissions-set branch November 13, 2026 07:35
@zimeg zimeg mentioned this pull request Nov 13, 2026
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant