Skip to content

ci: surface release notification errors for safe retries - #1700

Closed
zimeg wants to merge 2 commits into
mainfrom
notify-errors
Closed

zimeg wants to merge 2 commits into
mainfrom
notify-errors

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

This pull request sets errors: true on the Slack release announcement in the notify job, so a rejected post (e.g. a revoked webhook) fails the job instead of only logging.

  • notify is already its own job, so a red X there leaves the release green and signals gh run rerun <id> --failed. Nothing else changes.
  • Same change as the split notify jobs in bolt-js, node-slack-sdk, slack-github-action and slack-skills-plugin. Motivated by this suggestion on the python release-notify PRs.
  • zizmor .github/workflows/release.yml: no findings.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

Set errors: true on the Slack release announcement so a rejected post fails the notify job instead of only logging, which signals a retry with gh run rerun --failed.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 23:22
@zimeg zimeg added this to the 1.55.1 milestone Nov 13, 2026
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.95%. Comparing base (66ca90f) to head (fe5ada5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1700      +/-   ##
============================================
- Coverage     74.03%   73.95%   -0.09%     
+ Complexity     4758     4752       -6     
============================================
  Files           487      487              
  Lines         14811    14811              
  Branches       1536     1536              
============================================
- Hits          10965    10953      -12     
- Misses         2934     2943       +9     
- Partials        912      915       +3     
Flag Coverage Δ
jdk-14 73.95% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! Failing loud on a rejected webhook makes a missed announcement easy to spot and rerun.

@zimeg

zimeg commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

🙏 Thanks for the kind review @mwbrooks! #1701 already landed this same errors: true line on main, so I'm closing this one as superseded.

@zimeg zimeg closed this Nov 14, 2026
@zimeg
zimeg deleted the notify-errors branch November 14, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants