Skip to content

fix(types): include bot_profile in thread broadcasts - #2856

Merged
mwbrooks merged 1 commit into
mainfrom
mwbrooks-types-thread-broadcast-bot-profile
Nov 17, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
mwbrooks-types-thread-broadcast-bot-profile

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Summary

This pull request adds the optional bot_profile field to ThreadBroadcastMessageEvent, so developers can read the profile of the app that broadcast a thread reply without a type cast.

Testing

  • The thread_broadcast fixture in packages/types/test/events/message.test-d.ts now includes a bot_profile, and npm run test:types --workspace=@slack/types passes.

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I have signed the Salesforce CLA (required before your PR can be reviewed or merged). Not needed: maintainer and Salesforce employee.

@mwbrooks mwbrooks added this to the types@next milestone Nov 17, 2026
@mwbrooks mwbrooks added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch pkg:types applies to `@slack/types` labels Nov 17, 2026
@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d7cc4c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@slack/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mwbrooks mwbrooks self-assigned this Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.32%. Comparing base (bce2a92) to head (d7cc4c1).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
- Coverage   94.39%   94.32%   -0.07%     
==========================================
  Files          67       67              
  Lines       10808    10808              
  Branches      683      676       -7     
==========================================
- Hits        10202    10195       -7     
- Misses        576      583       +7     
  Partials       30       30              
Flag Coverage Δ
cli-hooks 94.26% <ø> (ø)
cli-test 94.26% <ø> (ø)
logger 94.26% <ø> (ø)
oauth 94.26% <ø> (ø)
socket-mode 94.26% <ø> (ø)
web-api 94.26% <ø> (ø)
webhook 94.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwbrooks
mwbrooks marked this pull request as ready for review November 17, 2026 00:21
@mwbrooks
mwbrooks requested a review from a team as a code owner November 17, 2026 00:21

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧱 @mwbrooks LGTM! Thanks for following up on the bot_profile suggestion.

@mwbrooks

Copy link
Copy Markdown
Member Author

Thanks @zimeg for the quick review! 🙇

@mwbrooks
mwbrooks merged commit fd8f6dd into main Nov 17, 2026
21 of 22 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-types-thread-broadcast-bot-profile branch November 17, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:types applies to `@slack/types` semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ThreadBroadcastMessageEvent is missing bot_id

2 participants