Repository navigation
fix(types): include bot_profile in thread broadcasts - #2856
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d7cc4c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
- Coverage 94.39% 94.32% -0.07%
==========================================
Files 67 67
Lines 10808 10808
Branches 683 676 -7
==========================================
- Hits 10202 10195 -7
- Misses 576 583 +7
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks @zimeg for the quick review! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the optional
bot_profilefield toThreadBroadcastMessageEvent, so developers can read the profile of the app that broadcast a thread reply without a type cast.bot_idto the same event and fixed ThreadBroadcastMessageEvent is missingbot_id#2766. Addingbot_profilewas suggested in that review.GenericMessageEventalready typesbot_profile?: BotProfile, and the Slack message event payload sends it next tobot_idandapp_id.Testing
thread_broadcastfixture inpackages/types/test/events/message.test-d.tsnow includes abot_profile, andnpm run test:types --workspace=@slack/typespasses.Requirements