Repository navigation
Conversation
Co-authored-by: Michael Brooks <21328+mwbrooks@users.noreply.github.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 20f820a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2860 +/- ##
==========================================
- Coverage 94.43% 94.35% -0.09%
==========================================
Files 67 67
Lines 10809 10814 +5
Branches 679 681 +2
==========================================
- Hits 10208 10204 -4
- Misses 572 577 +5
- Partials 29 33 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes
IncomingWebhook.send()use thefetch,timeoutandretryConfigoptions it's given.IncomingWebhookSendArgumentsextends the default arguments, sosend({ text, fetch, timeout, retryConfig })type-checks, but only the constructor's values were used.send()now uses the values given to it for that call and falls back to the constructor's when they're left out. Following fix(webhook): strip transport options from send() payloads #2857, they're still removed from the posted payload.Follows @mwbrooks's thought on #2857, which also mentioned dropping these from
IncomingWebhookSendArguments. Removing options from an exported type would break TypeScript code that passes them, so this honours them instead.Testing
mainand pass with this change.fetchgiven tosend()is the one called.send()timeout of 50ms and a reply delayed by 200ms,send()rejects withIncomingWebhookRequestErrorafter about 50ms.retryConfigon the constructor, aretryConfiggiven tosend()retries a 503 and resolves on the next 200.Requirements
🤖 Generated with Claude Code